Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consolidate deferred read, and document in Javadoc #207

Closed
attipaci opened this issue Nov 22, 2021 · 1 comment · Fixed by #396
Closed

Consolidate deferred read, and document in Javadoc #207

attipaci opened this issue Nov 22, 2021 · 1 comment · Fixed by #396
Assignees
@attipaci
Labels
enhancement A new feature and/or an improved capability style Better style and/or less bug-prone
Milestone
1.18.0

Comments

@attipaci
Copy link
Collaborator

attipaci commented Nov 22, 2021 •
edited

Currently deferred data reading is implemented separately for each Data subclass. Also, the deferred read behavior is not mentioned in Fits.readHDU() or Data.read() Javadocs. Therefore, this ticket has 2 specific goals:

  1. Implement deferred reading upstream in Data, rather than separate downstream implementations. (Subclasses could still call the common implementation in their read() methods if appropriate.
  2. Document deferred read behavior in the Javadoc markup of the affected methods.
@attipaci attipaci added enhancement A new feature and/or an improved capability style Better style and/or less bug-prone labels Nov 22, 2021
@attipaci attipaci added this to the Future milestone Nov 22, 2021
@attipaci attipaci self-assigned this Nov 22, 2021
@attipaci
Copy link
Collaborator Author

Some initial baby steps in this direction have been included in PR #323.

@attipaci attipaci modified the milestones: Future, 1.18.0 Sep 28, 2022
@attipaci attipaci modified the milestones: 1.18.0, Future Mar 26, 2023
@attipaci attipaci closed this as not planned Won't fix, can't repro, duplicate, stale Apr 3, 2023
@attipaci attipaci reopened this Apr 3, 2023
@attipaci attipaci modified the milestones: Future, 1.18.0 Apr 3, 2023
@attipaci attipaci linked a pull request Apr 4, 2023 that will close this issue
Consistent deferred read and Data implementations #396
Merged
@attipaci attipaci pinned this issue Apr 4, 2023
@attipaci attipaci unpinned this issue Apr 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@attipaci attipaci

Labels
enhancement A new feature and/or an improved capability style Better style and/or less bug-prone
Projects
None yet
Milestone
1.18.0
Development

Successfully merging a pull request may close this issue.

Consistent deferred read and Data implementations attipaci/nom-tam-fits
1 participant
@attipaci