Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for null (undefined) values in logical binary table columns #451

Closed
attipaci opened this issue Jun 20, 2023 · 0 comments · Fixed by #442
Closed

Support for null (undefined) values in logical binary table columns #451

attipaci opened this issue Jun 20, 2023 · 0 comments · Fixed by #442
Assignees
Labels
enhancement A new feature and/or an improved capability standard Improved compliance to FITS standard
Milestone

Comments

@attipaci
Copy link
Collaborator

attipaci commented Jun 20, 2023

FITS logical columns in binary tables can store true/false values but also undefined (null) values, as the bytes 'T', 'F', and 0 respectively. So far we have not supported the undefined (null) values because we identified logical columns with the Java primitive boolean, which can have only true/false states. (On that note, booleans can be better supported by bit-based columns, see #450).

We should allow creating, setting, and accessing logical columns as the boxed Java Boolean values, which may be null to signify undefined logical values in binary tables.

Thus, addColumn(), setElement(), setColumn() and setRow() may thus accept arrays of Boolean. However, to keep our code backward compatible, getElement(), getRow(), and getColumn()will return values asbooleanarrays. As such we need new methods to access logical column data asBooleanvalues, at least on the element level. (see newBinaryTable.get()` method in #448)

@attipaci attipaci added enhancement A new feature and/or an improved capability standard Improved compliance to FITS standard labels Jun 20, 2023
@attipaci attipaci added this to the 1.18.0 milestone Jun 20, 2023
@attipaci attipaci self-assigned this Jun 20, 2023
@attipaci attipaci linked a pull request Jun 20, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement A new feature and/or an improved capability standard Improved compliance to FITS standard
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant