Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Variable-length complex column array descriptors are incorrect #455

Closed
attipaci opened this issue Jun 27, 2023 · 1 comment
Closed

Variable-length complex column array descriptors are incorrect #455

attipaci opened this issue Jun 27, 2023 · 1 comment
Assignees
Labels
breaking-potential Alters functionality in ways that may break prior application. bug Erroneous behavior of the existing code standard Improved compliance to FITS standard
Milestone

Comments

@attipaci
Copy link
Collaborator

attipaci commented Jun 27, 2023

When storing variable-length data in FITS, the main table contains only array descriptors, which locate the data on the heap. The descriptor consists of an element count, and a heap byte offset.

However, prior to 1.18, we used the count of Java elements, rather than the count of FITS elements. Thus, when complex values were stored, the length component indicated the number of float or double components, which are a factor of 2 larger than the number of expected complex components. While our library would read this back fine (hence tests passed), other libraries would not be able to properly read FITS produced by us as a result.

This issue is resolved in PR #442

@attipaci attipaci added bug Erroneous behavior of the existing code breaking-potential Alters functionality in ways that may break prior application. standard Improved compliance to FITS standard labels Jun 27, 2023
@attipaci attipaci added this to the 1.18.0 milestone Jun 27, 2023
@attipaci attipaci self-assigned this Jun 27, 2023
@attipaci attipaci pinned this issue Jun 29, 2023
@attipaci
Copy link
Collaborator Author

attipaci commented Jul 5, 2023

Merged with PR #442.

@attipaci attipaci closed this as completed Jul 5, 2023
@attipaci attipaci unpinned this issue Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-potential Alters functionality in ways that may break prior application. bug Erroneous behavior of the existing code standard Improved compliance to FITS standard
Projects
None yet
Development

No branches or pull requests

1 participant