Demote FitsException to a runtime exception #519
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tateException" This reverts commit a46ccda.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #519 +/- ##
============================================
+ Coverage 97.65% 97.69% +0.04%
- Complexity 4779 4790 +11
============================================
Files 207 209 +2
Lines 13796 13781 -15
Branches 2122 2123 +1
============================================
- Hits 13472 13463 -9
+ Misses 122 117 -5
+ Partials 202 201 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
…rameter.nextFreeZVal()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the inception of this library
FitsExceptionwas a hard exception that forced programmers to deal with it. However, its meaning is much more similar conceptually to Java'sIllegalStateException-- which is a soft runtime exception. Therefore, let's changeFitsException(and its derivatives such asHeaderCardExcepton) to be a FITS-specific subclass ofIllegalStateExceptiongoing forward.The change is entirely backward compatible from a developer's point of view. The
catchblocks that were necessary before still work the same, only they are now optional.As a result of the change the internal
nom.fits.compression.provider.param.api.IHeaderAccessinterface, its subclasses and usage have become obsoleted and unnecessary. These have been marked as deprecated to be removed in a future release (such as 2.0).Some further tweaks in PR #530