removal of redundent attribute "rowSize" #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks fine. However I think that the release notes need to include a mention note that the deletColumns method in ColumnTable has changed from int to void. I don't think it's too likely that anyone is using that class somewhere else, but it's a breaking change to the nominally public interface. |
|
Ok, I will write it in the release notes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@TomMcGlynn the rowSize attribute caused problems during the binary compression implementation. And will also cause problems when you add a empty column (no rows yet) and add the rows afterward (fixed that in the head).
But the rowSize attribute is redundant and not necessary, as far as I can see. This pull request contains the changes necessary to delete the attribute, and still have all tests succeed.
@TomMcGlynn could you verify, that my change is correct? If it is just push the merge pull request button.