Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature: preflight reverts in fixed-gas actions #97

Open
prestwich opened this issue Apr 14, 2022 · 2 comments
Open

feature: preflight reverts in fixed-gas actions #97

prestwich opened this issue Apr 14, 2022 · 2 comments
Labels
fix good first issue Good for newcomers

Comments

@prestwich
Copy link
Member

currently reverts in certain actions are not caught in pre-flight because we no longer estimate gas. We should run an eth_call to see if they would cause a revert and take appropriate action

example action:
update on a failed home
@prestwich prestwich added the fix label Apr 14, 2022
@luketchang luketchang added the good first issue Good for newcomers label May 9, 2022
@ef3n9r98

This comment was marked as off-topic.

Sign in to view
@prestwich
Copy link
Member Author

Please do not use this space for advertising or sales

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
fix good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@prestwich @luketchang @ef3n9r98