Skip to content
This repository has been archived by the owner on Jun 20, 2021. It is now read-only.

Add missing fields in pending renewal info #82

Merged
merged 2 commits into from Dec 5, 2019
Merged

Add missing fields in pending renewal info #82

merged 2 commits into from Dec 5, 2019

Conversation

ohbarye
Copy link
Contributor

@ohbarye ohbarye commented Dec 5, 2019

Issue

Compared to Apples' guide of pending renewal info, I found those missing fields below.

  • grace_period_expires_date
  • grace_period_expires_date_ms
  • grace_period_expires_date_pst
  • original_transaction_id

Changes

I added the missing fields into Venice::PendingRenewalInfo.

  1. grace_period_expires_at
    • It doubles grace_period_expires_date, grace_period_expires_date_ms, and grace_period_expires_date_pst.
  2. original_transaction_id

dankimio
dankimio approved these changes Dec 5, 2019
View reviewed changes
Copy link
Member

@dankimio dankimio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@dankimio dankimio merged commit 59c162c into nomad-cli:master Dec 5, 2019
@ohbarye ohbarye deleted the add-missing-fields-of-pending-renewal-info branch December 5, 2019 14:59
@ohbarye
Copy link
Contributor Author

ohbarye commented Dec 5, 2019

Thanks for your fast review!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dankimio dankimio dankimio approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ohbarye @dankimio