Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Background color for table heading rows does not work #50

Closed
RonaldPR opened this issue May 12, 2023 · 3 comments
Closed

Background color for table heading rows does not work #50

RonaldPR opened this issue May 12, 2023 · 3 comments

Comments

@RonaldPR
Copy link

RonaldPR commented May 12, 2023

While playing with Template Style Settings, I found that "The background color for table heading rows" does not work.

Regardless the chosen color, the background color in table heading rows remain the same as the main background color, #ffffff in Light mode and #222222 in Dark mode.

The generated html looks OK to me (heading row plus first row):

                                    <div class="table sectionedit3">
                                        <table class="inline">
                                            <thead>
                                                <tr class="row0">
                                                    <th class="col0"> Guest </th>
                                                    <th class="col1"> Default build </th>
                                                    <th class="col2"> Sound-enabled build </th>
                                                    <th class="col3"> Specific arguments </th>
                                                    <th class="col4"> Remarks </th>
                                                </tr>
                                            </thead>
                                            <tr class="row1">
                                                <td class="col0 leftalign"> Mac OS 9.0         </td>
                                                <td class="col1 leftalign"> OK            </td>
                                                <td class="col2 leftalign"> Needs -cpu G3          </td>
                                                <td class="col3"> -M mac99 </td>
                                                <td class="col4"> Requires rom version 5.2.1 or above, mouse wiggle to boot </td>
                                            </tr>

So I suppose it is a css issue

Also a minor textual error in the style settings page, both with light mode and dark mode settings:
The background color for table odd rows
The background color for table odd rows

The second one should be named
The background color for table even rows

@nomadjimbob
Copy link
Owner

Thanks for letting me know. The latest update fixes this issue and exposes table text colouring options incase the base text colour does not work with the header/row background colours.

@RonaldPR
Copy link
Author

RonaldPR commented May 13, 2023 via email

@nomadjimbob
Copy link
Owner

Awesome work. Thanks for the nostalgia trip back to when I used to own a Mac Classic II with System 6, trying to make games in Hypercard!

If there are any improvements you would like to see in this theme, or the MikioPlugin, don't hesitate to open an issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants