Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

arbtt-stats --intervals UTC? #82

Closed
nomeata opened this issue Aug 30, 2015 · 7 comments
Closed

arbtt-stats --intervals UTC? #82

nomeata opened this issue Aug 30, 2015 · 7 comments

Comments

@nomeata
Copy link
Owner

nomeata commented Aug 30, 2015

Original report by amenthes (Bitbucket: amenthes, GitHub: amenthes).


It appears that the --intervals flag outputs UTC rather than local timezone. This in itself isn't a problem, but it should be documented if it is intended like this.

For example, i just ran the command:

> arbtt-stats --intervals Program:firefox
Program:firefox | 08/30/15 11:54:23 | 08/30/15 12:06:23 |   13m00s
Program:firefox | 08/30/15 12:51:24 | 08/30/15 12:54:24 |    4m00s    
Program:firefox | 08/30/15 12:58:42 | 08/30/15 12:59:42 |    2m00s

my local time is 15:01 (13:01 UTC +02:00 CEST) right now, and those are the intervals from just a few minutes ago.

Again: is this intentional or could it be related to something in my setup?

@nomeata
Copy link
Owner Author

nomeata commented Aug 31, 2015

Original comment by nomeata (Bitbucket: nomeata, GitHub: nomeata).


Indeed, it is UTC there. I guess that is mostly laziness on my part (I will have to pass the timezone down to the relevant function), but should be no problem. I’ll look into it; as I mentioned I’m currently traveling.

@nomeata
Copy link
Owner Author

nomeata commented Aug 31, 2015

Original comment by amenthes (Bitbucket: amenthes, GitHub: amenthes).


If it is always UTC, i am not at all against this. In that case, it would just need a notice in the docs. What i certainly would like to avoid would be "undefinedness" as in "you get some output, but you can't tell what exactly it is".

@nomeata
Copy link
Owner Author

nomeata commented Sep 5, 2018

Original comment by Michał J Gajda (Bitbucket: [Michal J. Gajda](https://bitbucket.org/Michal J. Gajda), ).


Fixed in my branch: https://bitbucket.org/mgajda/arbtt/commits/c69448224b29476b91456e3c844d979e6aae4a98

@nomeata
Copy link
Owner Author

nomeata commented Jan 26, 2019

Original comment by nomeata (Bitbucket: nomeata, GitHub: nomeata).


This has been merged into master, and released in 0.10.1.

@nomeata nomeata closed this as completed Jan 26, 2019
@nomeata
Copy link
Owner Author

nomeata commented Jan 26, 2019

Original comment by amenthes (Bitbucket: amenthes, GitHub: amenthes).


This is what I was afraid of. Now the worst of two combinations has happened (and this is the exact opposite of what this ticket was about):

a) it is still not documented what the expected format is (documentation has not changed).
b) the format of that output changed without advance notice from UTC to local timezone.

Additionally, there is no way to get back the old way, in case anyone depends on the specific output.

Did anyone test what happens to the output with regard to daylight savings time? Let's say I'm running this command in december (Where I am in UTC+01:00) and want to see intervals from september (where they have been recorded in UTC+02:00) what happens now? At least with UTC (and before merging this) it was consistently UTC.

@nomeata
Copy link
Owner Author

nomeata commented Jan 26, 2019

Original comment by nomeata (Bitbucket: nomeata, GitHub: nomeata).


Dates are hard :-/

@nomeata
Copy link
Owner Author

nomeata commented Jan 26, 2019

Original comment by Michał J Gajda (Bitbucket: [Michal J. Gajda](https://bitbucket.org/Michal J. Gajda), ).


@Amenthes Is it another bug report, or rather documentation request?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant