Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Models: Remove system prompt of Nous-Hermes-2-Mistral-7b-DPO #2054

Merged
merged 3 commits into from Mar 1, 2024
Merged

Models: Remove system prompt of Nous-Hermes-2-Mistral-7b-DPO #2054

merged 3 commits into from Mar 1, 2024

Conversation

ThiloteE
Copy link
Collaborator

@ThiloteE ThiloteE commented Feb 28, 2024 •
edited

Describe your changes

  • Adds "accepts various system prompts"
  • Removes system prompt
  • fix whitespace

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • I have added thorough documentation for my code.
  • I have tagged PR with relevant project labels. I acknowledge that a PR without labels may be dismissed.
  • If this PR addresses a bug, I have provided both a screenshot/video of the original bug and the working solution.

Notes

Reason for removing the system prompt:

  • The current system prompt is suboptimal.
  • The dataset barely contains system prompts,
  • Rudimentary small tests show that various system prompts work with this model without causing extreme "bleeding" into the responses, but since the tests were not extensive, I would like to go the "safe" route and remove the given system prompt, as it works very well without system prompt.

Co-authored-by: 3Simplex 10260755+3Simplex@users.noreply.github.com"

@ThiloteE
Remove system prompt of Nous-Hermes-2-Mistral-7b-DPO
df1cec4 
- Add "accepts various system prompts"
- Remove system prompt
- fix whitespace

Signed-off-by: ThiloteE <73715071+ThiloteE@users.noreply.github.com>
@ThiloteE ThiloteE changed the title Remove system prompt of Nous-Hermes-2-Mistral-7b-DPO Models: Remove system prompt of Nous-Hermes-2-Mistral-7b-DPO Feb 29, 2024
@ThiloteE ThiloteE added the models.json This requires a change to the official model list. label Feb 29, 2024
@ThiloteE
Remove System Prompt completely
5159465 
Signed-off-by: ThiloteE <73715071+ThiloteE@users.noreply.github.com>
@ThiloteE @cebtenzzre
Keep systemPrompt key
d3d31df 
Co-authored-by: Jared Van Bortel <cebtenzzre@gmail.com>
Signed-off-by: ThiloteE <73715071+ThiloteE@users.noreply.github.com>
@cebtenzzre cebtenzzre merged commit f2b4809 into nomic-ai:main Mar 1, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cebtenzzre cebtenzzre cebtenzzre approved these changes

Assignees
No one assigned
Labels
models.json This requires a change to the official model list.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ThiloteE @cebtenzzre