Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for tsc 5.3 #133

Closed
Griffork opened this issue Nov 7, 2023 · 5 comments
Closed

Support for tsc 5.3 #133

Griffork opened this issue Nov 7, 2023 · 5 comments

Comments

@Griffork
Copy link

Griffork commented Nov 7, 2023

Typescript 5.3 reports a Consolidation Between tsserverlibrary.js and typescript.js

Which I imagine means some of the hooks need to be changed and/or how the pathc is installed needs to change.

When will this be supported/is it already supported?

@samchon
Copy link
Sponsor Contributor

samchon commented Nov 8, 2023

Not working on ts 5.3 beta

@nonara
Copy link
Owner

nonara commented Nov 8, 2023

@Griffork I assume consolidation won't change anything.

@samchon I haven't tried yet. But we'll make sure it works before release. Is it failing to patch all binaries or do you get a specific error message?

@samchon
Copy link
Sponsor Contributor

samchon commented Nov 8, 2023

I will make a reproducible repo after an hour. Thanks for quick response

@nonara
Copy link
Owner

nonara commented Nov 8, 2023

@samchon Thanks! No need to make a repro, though. I'll use the main repo + tests.

But if you have any diagnostic info, feel free to share here!

@samchon
Copy link
Sponsor Contributor

samchon commented Nov 8, 2023

@Griffork @nonara I'm sorry, it was mis-reporting.

About the TypeScript v5.3 beta update, no issues with normal ts-patch use cases.

In my typia case, the problem just appeared by break change of ts.factory.createNumericLiteral() function.

It does not allow native value more like below error message.

ts.factory.createNumericLiteral(-127);
Error: Debug Failure. False expression: Negative numbers should be created in combination with createPrefixUnaryExpression

@nonara nonara closed this as completed in 15570d0 Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants