fix: compilation fails if basedir resolves to cwd #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Process.cwd missed the function call resulting in compilation error when baseDir resolved to process.cwd. TS version: 4.3.5
|
Yikes! Good catch. Thanks for the contribution! |
|
Released in |
|
It was my pleasure! I really like to work with custom transforms, ts-patch saved me a lot of time in the past few weeks. Thanks for maintaining this lib and for the quick merge! I hope I can contribute more then just a pair of brackets in the future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Process.cwd missed the function call resulting in compilation error when baseDir resolved to process.cwd.
TS version: 4.3.5