Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle color keywords #1

Closed
rnons opened this issue Jul 16, 2019 · 1 comment
Closed

Handle color keywords #1

rnons opened this issue Jul 16, 2019 · 1 comment

Comments

@rnons
Copy link
Collaborator

rnons commented Jul 16, 2019 •
edited
Loading

  1. getValues "color" should return a list of color keywords
  2. Same for getValues "background-color" and getValues "border-color"
  3. Please add some tests, don't forget to test transparent and currentColor

I think we should be able to get the color keywords list from csstree.

I just realized there are more *-color css properties, ideally we should use csstree syntax to find out which property accepts <color> value, and return the color keywords in getValues "*-color".
@kahlil29
Copy link

I will be attempting to solve this issue 😄

@PanAeon PanAeon mentioned this issue Aug 7, 2019
Closed
@rnons rnons closed this as completed Aug 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Handle color keywords. Upgrade css-tree to 1.0.0-alpha.34 PanAeon/purescript-css-properties
2 participants
@rnons @kahlil29