Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the Option to Define Default Backing Store by the User Explicitly #7204

Closed
shirady opened this issue Feb 9, 2023 · 3 comments
Closed

Comments

@shirady
Copy link
Contributor

shirady commented Feb 9, 2023

Is your feature request related to a problem? Please describe.
Not a problem, an improvement.

Describe the solution you'd like
I want to have an explicit command to define the default resource in the CLI (and in the operator in general).

Describe alternatives you've considered

  1. Leave it as is, today I used an RPC call update_account_s3_access to change the default resource.
  2. Create another RPC call that is quite similar to update_account_s3_access just more simple (email and default_resource as required fields only) and with a meaningful name.
  3. Have an explicit command to define the default resource.
@shirady
Copy link
Contributor Author

shirady commented Feb 13, 2023

After I talked with @dannyzaken:

  1. Moving this issue to the core repo.
  2. We don't create RPC calls for every specific use. Instead, we will remove the required field of s3_access - the use of it was historical: before the UI was deprecated we had two types of accounts account UI and account access S3, account UI was for using the UI and it didn't have s3_access. Today, all of our accounts have it.

@shirady shirady transferred this issue from noobaa/noobaa-operator Feb 13, 2023
@nimrod-becker
Copy link
Contributor

@dannyzaken how does this differ from the work on the default BS ?

@dannyzaken
Copy link
Contributor

Closing this issue after discussing with @shirady. there is not real need to change the API right now. changing the default resource can be done by the CLI with NooobaaAccount CR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants