Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NC | Health | Remove rsyslog/syslog_ng checks #8094

Merged
merged 1 commit into from
May 29, 2024
Merged

NC | Health | Remove rsyslog/syslog_ng checks #8094

merged 1 commit into from
May 29, 2024

Conversation

romayalon
Copy link
Contributor

@romayalon romayalon commented May 29, 2024 •
edited

Explain the changes

  1. Health.js - removed rsyslog/syslog_ng checks from health script.
  2. Removed rsyslog/syslog_ng related tests.
  3. Removed rsyslog/syslog_ng references from docs.

Issues: Fixed #xxx / Gap #xxx

  1. Fixed Config-Option to deactivate rsyslog if syslogng are used  #8046
  2. Fixed Incorrect service status for rsyslog if syslog-ng enables #8027
  3. Fixed No error code for inactive syslog-ng service #8024

Testing Instructions:

  • Doc added/updated
  • Tests added

@romayalon
NC | Health | Remove rsyslog/syslog_ng tracking
7a7b3df 
Signed-off-by: Romy <35330373+romayalon@users.noreply.github.com>
@romayalon romayalon merged commit 958ad06 into noobaa:master May 29, 2024
10 checks passed
@romayalon romayalon mentioned this pull request May 29, 2024
Merged
2 tasks
@guymguym guymguym added this to the 5.15.4 milestone May 29, 2024
This was referenced Jun 16, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guymguym guymguym guymguym approved these changes

@naveenpaul1 naveenpaul1 Awaiting requested review from naveenpaul1

Assignees
No one assigned
Labels
size/L
Projects
None yet
Milestone
5.15.4
2 participants
@romayalon @guymguym