Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] No loading icon on create module button #330

Closed
BlueZeeKing opened this issue Oct 26, 2023 · 3 comments
Closed

[BUG] No loading icon on create module button #330

BlueZeeKing opened this issue Oct 26, 2023 · 3 comments
Labels
bug Something isn't working

Comments

@BlueZeeKing
Copy link
Contributor

Describe the bug
When creating a new module the button does not change to show a loading state. This can lead to confusion and the user clicking the button multiple times.

To Reproduce
Create a new module with a slow internet (use network throttling in chrome dev tools if needed)

Expected behavior
The button should show a loading icon

Screenshots
Screenshot 2023-10-26 at 12 16 47 PM
What a loading button should look like with NextUI

Information (please complete the following information):

  • Node version [e.g. 18.17.0] v18.18.2
  • Pnpm version [e.g. 8.9.2] 8.9.2

Additional context
Add any other context about the problem here.
Sorry for not creating this issue before submitting a PR

@BlueZeeKing BlueZeeKing added the bug Something isn't working label Oct 26, 2023
@BlueZeeKing
Copy link
Contributor Author

Completed by #329

@keshav-gupta19
Copy link

Is the issue solved or can i work on this??

@BlueZeeKing
Copy link
Contributor Author

Is the issue solved or can i work on this??

It is solved, just waiting to be merged in #329

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants