Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow build without env variables #344

Closed
Byteingpython opened this issue Nov 1, 2023 · 1 comment
Closed

Allow build without env variables #344

Byteingpython opened this issue Nov 1, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@Byteingpython
Copy link

Is your feature request related to a problem? Please describe.
Noodle is in its current state noy able to be shipped in any prebuilt form (e.g. Docker Container) Because the Environment variables are needed for the build.

Describe the solution you'd like
A way to only provide those env Variables at runtime

Describe alternatives you've considered
Dont ship any prebuilds

@Byteingpython Byteingpython added the enhancement New feature or request label Nov 1, 2023
@Byteingpython Byteingpython changed the title Allow for build without env variables Allow build without env variables Nov 1, 2023
@ixahmedxi
Copy link
Collaborator

I actually disagree with this because of a few reasons:

  • without the build failure due to missing environment variables, noodle will not work as intended at all. it won't be able to connect to a db or provide authentication.
  • A docker image for Noodle should have the capabilities of providing these environment variables in the image's config (like how the Postgres image works for example) and it should fail if these aren't provided as well.

I know it might be a pain at first, but it ensures that the application will work as intended and t3-env is a great package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants