Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emotes are not always parsed when editing edited messages. #5

Closed
noodlebox opened this issue Sep 28, 2016 · 0 comments
Closed

Emotes are not always parsed when editing edited messages. #5

noodlebox opened this issue Sep 28, 2016 · 0 comments
Labels
Milestone

Comments

@noodlebox
Copy link
Owner

When editing a text-only message that has been edited at least once before, emote parsing is not triggered on the new content.

This most likely happens because ReactJS (in trying to minimize DOM changes) simply changes the data for the text node, which does not trigger the observer callback. If a message had not been edited before, the adding of the "(edited)" tag triggers the callback. If there are any existing emotes, a new text node is created as a child of the img element (the cause of a previously fixed bug), also triggering the callback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant