fix(linting): add jshint for unused variables, delint codebase

.jshintrc

@@ -17,6 +17,7 @@
   "strict": true,
   "trailing":true,
   "undef":true,
+  "unused":"vars",
   "esnext":true,
   "globals": {
     "Promise": true

examples/eventhub_management_request.js

@@ -44,7 +44,6 @@ if (settings.serviceBusHost.indexOf(".") !== -1) {
 var sasName = settings.SASKeyName;
 var sasKey = settings.SASKey;
 var eventHubName = settings.eventHubName;
-var numPartitions = settings.partitions;
 
 var uri = protocol + '://' + encodeURIComponent(sasName) + ':' + encodeURIComponent(sasKey) + '@' + serviceBusHost;
 var managementEndpoint = '$management';

lib/adapters/translate_encoder.js

@@ -11,7 +11,6 @@ var processor = require('node-amqp-encoder').Processor,
 
 var encoder = processor({
   number: function(type, val) {
-    var absval;
     switch (type) {
       case 'ulong':
       case 'long':

lib/amqp_client.js

@@ -6,26 +6,15 @@ var EventEmitter = require('events').EventEmitter,
     util = require('util'),
 
     Connection = require('./connection'),
-    M = require('./types/message'),
     Sasl = require('./sasl'),
     Session = require('./session'),
-    Link = require('./link'),
 
-    constants = require('./constants'),
     errors = require('./errors'),
-    DescribedType = require('./types/described_type'),
-    Fields = require('./types/amqp_composites').Fields,
-    ForcedType = require('./types/forced_type'),
-    ST = require('./types/source_target'),
-    DeliveryStates = require('./types/delivery_state'),
-    Source = ST.Source,
-    Target = ST.Target,
 
     translator = require('./adapters/translate_encoder'),
     DefaultPolicy = require('./policies/default_policy'),
 
-    u = require('./utilities'),
-    putils = require('./policies/policy_utilities');
+    u = require('./utilities');
 
 
 

lib/codec.js

@@ -1,11 +1,6 @@
 'use strict';
 
-var debug = require('debug')('amqp10:codec'),
-    util = require('util'),
-    builder = require('buffer-builder'),
-    Int64 = require('node-int64'),
-
-    constants = require('./constants'),
+var Int64 = require('node-int64'),
 
     AMQPArray = require('./types/amqp_composites').Array,
     DescribedType = require('./types/described_type'),
@@ -16,8 +11,6 @@ var debug = require('debug')('amqp10:codec'),
     errors = require('./errors'),
     types = require('./types');
 
-
-
 /**
  * Build a codec.
  *

lib/connection.js

@@ -11,12 +11,10 @@ var EventEmitter = require('events').EventEmitter,
     StateMachine = require('stately.js'),
 
     constants = require('./constants'),
-    codec = require('./codec'),
     errors = require('./errors'),
     u = require('./utilities'),
 
     AMQPError = require('./types/amqp_error'),
-    DescribedType = require('./types/described_type'),
 
     FrameReader = require('./frames/frame_reader'),
     CloseFrame = require('./frames/close_frame'),

lib/constants.js

@@ -1,7 +1,6 @@
 'use strict';
 
-var Int64 = require('node-int64'),
-    Builder = require('buffer-builder');
+var Builder = require('buffer-builder');
 
 function amqpify(arr) {
   var b = new Builder();

lib/frames/attach_frame.js

@@ -1,14 +1,12 @@
 'use strict';
 
-var debug = require('debug')('amqp10:framing:attach'),
-    util = require('util'),
+var util = require('util'),
     Int64 = require('node-int64'),
     _ = require('lodash'),
 
     constants = require('../constants'),
     errors = require('../errors'),
     u = require('../utilities'),
-    up = u.payload,
 
     DescribedType = require('../types/described_type'),
     ForcedType = require('../types/forced_type'),
@@ -18,8 +16,6 @@ var debug = require('debug')('amqp10:framing:attach'),
 
     FrameBase = require('./frame');
 
-
-
 /**
  * <h2>attach performative</h2>
  * <i>attach a Link to a Session</i>

lib/frames/begin_frame.js

@@ -1,22 +1,18 @@
 'use strict';
 
-var debug = require('debug')('amqp10:framing:begin'),
-    util = require('util'),
+var util = require('util'),
     Int64 = require('node-int64'),
     _ = require('lodash'),
 
     constants = require('../constants'),
     u = require('../utilities'),
-    up = u.payload,
 
     DescribedType = require('../types/described_type'),
     ForcedType = require('../types/forced_type'),
     AMQPSymbol = require('../types/amqp_symbol'),
 
     FrameBase = require('./frame');
 
-
-
 /**
  * <h2>begin performative</h2>
  * <i>begin a Session on a channel</i>

lib/frames/close_frame.js

@@ -1,21 +1,14 @@
 'use strict';
 
-var debug = require('debug')('amqp10:framing:close'),
-    util = require('util'),
+var util = require('util'),
     Int64 = require('node-int64'),
 
-    constants = require('../constants'),
-    u = require('../utilities'),
-    up = u.payload,
-
     AMQPError = require('../types/amqp_error'),
     DescribedType = require('../types/described_type'),
     AMQPSymbol = require('../types/amqp_symbol'),
 
     FrameBase = require('./frame');
 
-
-
 /**
  * <h2>close performative</h2>
  * <i>signal a Connection close</i>

lib/frames/detach_frame.js

@@ -1,11 +1,9 @@
 'use strict';
 
-var debug = require('debug')('amqp10:framing:detach'),
-    util = require('util'),
+var util = require('util'),
     Int64 = require('node-int64'),
     _ = require('lodash'),
 
-    constants = require('../constants'),
     u = require('../utilities'),
     up = u.payload,
 
@@ -15,8 +13,6 @@ var debug = require('debug')('amqp10:framing:detach'),
 
     FrameBase = require('./frame');
 
-
-
 /**
  * <h2>detach performative</h2>
  * <i>detach the Link Endpoint from the Session</i>

lib/frames/disposition_frame.js

@@ -1,11 +1,9 @@
 'use strict';
 
-var debug = require('debug')('amqp10:framing:disposition'),
-    util = require('util'),
+var util = require('util'),
     Int64 = require('node-int64'),
     _ = require('lodash'),
 
-    constants = require('../constants'),
     u = require('../utilities'),
     up = u.payload,
 
@@ -15,8 +13,6 @@ var debug = require('debug')('amqp10:framing:disposition'),
 
     FrameBase = require('./frame');
 
-
-
 /**
  * <h2>disposition performative</h2>
  * <i>inform remote peer of delivery state changes</i>

lib/frames/end_frame.js

@@ -1,22 +1,14 @@
 'use strict';
 
-var debug = require('debug')('amqp10:framing:end'),
-    util = require('util'),
+var util = require('util'),
     Int64 = require('node-int64'),
 
-    constants = require('./../constants'),
-    u = require('../utilities'),
-    up = u.payload,
-
     AMQPError = require('../types/amqp_error'),
     DescribedType = require('../types/described_type'),
-    ForcedType = require('../types/forced_type'),
     AMQPSymbol = require('../types/amqp_symbol'),
 
     FrameBase = require('./frame');
 
-
-
 /**
  * <h2>end performative</h2>
  * <i>end the Session</i>

lib/frames/flow_frame.js

@@ -1,11 +1,9 @@
 'use strict';
 
-var debug = require('debug')('amqp10:framing:flow'),
-    util = require('util'),
+var util = require('util'),
     Int64 = require('node-int64'),
     _ = require('lodash'),
 
-    constants = require('../constants'),
     u = require('../utilities'),
     up = u.payload,
 
@@ -15,8 +13,6 @@ var debug = require('debug')('amqp10:framing:flow'),
 
     FrameBase = require('./frame');
 
-
-
 /**
  * <h2>flow performative</h2>
  * <i>update link state</i>

lib/frames/frame.js

@@ -64,7 +64,6 @@ Frame.prototype._writePayload = function(bufBuilder, options) {
 };
 
 Frame.prototype.write = function(outStream, options) {
-  var isAMQP = this.frameType === constants.frameType.amqp;
   var bufBuilder = new Builder();
   bufBuilder.appendUInt32BE(0); // Size placeholder
 

lib/frames/open_frame.js

@@ -1,22 +1,18 @@
 'use strict';
 
-var debug = require('debug')('amqp10:framing:open'),
-    Int64 = require('node-int64'),
+var Int64 = require('node-int64'),
     util = require('util'),
     _ = require('lodash'),
 
     constants = require('../constants'),
     u = require('../utilities'),
-    up = u.payload,
 
     DescribedType = require('../types/described_type'),
     ForcedType = require('../types/forced_type'),
     AMQPSymbol = require('../types/amqp_symbol'),
 
     FrameBase = require('./frame');
 
-
-
 /**
  * <h2>open performative</h2>
  * <i>negotiate Connection parameters</i>

lib/frames/sasl_frame.js

@@ -1,7 +1,6 @@
 'use strict';
 
-var debug = require('debug')('amqp10:framing:sasl'),
-    util = require('util'),
+var util = require('util'),
     Int64 = require('node-int64'),
 
     codec = require('./../codec'),
@@ -17,8 +16,6 @@ var debug = require('debug')('amqp10:framing:sasl'),
 
     FrameBase = require('./frame');
 
-
-
 /**
  * Base Frame for SASL authentication.
  *

lib/frames/transfer_frame.js

@@ -1,12 +1,9 @@
 'use strict';
 
-var debug = require('debug')('amqp10:framing:transfer'),
-    util = require('util'),
+var util = require('util'),
     Int64 = require('node-int64'),
-    Builder = require('node-amqp-encoder').Builder,
     _ = require('lodash'),
 
-    constants = require('../constants'),
     u = require('../utilities'),
     up = u.payload,
 
@@ -16,8 +13,6 @@ var debug = require('debug')('amqp10:framing:transfer'),
 
     FrameBase = require('./frame');
 
-
-
 /**
  * <h2>transfer performative</h2>
  * <i>transfer a Message</i>

lib/link.js

@@ -1,20 +1,16 @@
 'use strict';
 
-var _ = require('lodash'),
-    EventEmitter = require('events').EventEmitter,
+var EventEmitter = require('events').EventEmitter,
     Promise = require('bluebird'),
     util = require('util'),
 
     StateMachine = require('stately.js'),
 
     debug = require('debug')('amqp10:link'),
-    constants = require('./constants'),
     u = require('./utilities'),
 
     AttachFrame = require('./frames/attach_frame'),
-    DetachFrame = require('./frames/detach_frame'),
-
-    Session = require('./session');
+    DetachFrame = require('./frames/detach_frame');
 
 function Link(session, handle, linkPolicy) {
   this.policy = linkPolicy;

lib/receiver_link.js

@@ -1,11 +1,9 @@
 'use strict';
 
 var _ = require('lodash'),
-    Promise = require('bluebird'),
     util = require('util'),
     debug = require('debug')('amqp10:link:receiver'),
 
-    errors = require('./errors'),
     constants = require('./constants'),
     u = require('./utilities'),
 

lib/sasl.js

@@ -5,21 +5,13 @@ var debug = require('debug')('amqp10:sasl'),
     _ = require('lodash'),
 
     constants = require('./constants'),
-    codec = require('./codec'),
     errors = require('./errors'),
     u = require('./utilities'),
 
-    AMQPError = require('./types/amqp_error'),
-    DescribedType = require('./types/described_type'),
     AMQPSymbol = require('./types/amqp_symbol'),
-
-    FrameReader = require('./frames/frame_reader'),
     SaslFrames = require('./frames/sasl_frame'),
-
     Connection = require('./connection');
 
-
-
 /**
  * Currently, only supports SASL-PLAIN
  *

lib/session.js

@@ -124,8 +124,6 @@ function Session(conn) {
 
   this._linksByRemoteHandle = {};
 
-
-  var self = this;
   var stateMachine = {
     'UNMAPPED': {
       sendBegin: function() {