Skip to content

Commit

Permalink
feat(dynamic-links): prepend dynamic links with dynamic_
Browse files Browse the repository at this point in the history
  • Loading branch information
mbroadst committed Apr 4, 2016
1 parent 82daecb commit 69960e0
Show file tree
Hide file tree
Showing 4 changed files with 23 additions and 1 deletion.
10 changes: 9 additions & 1 deletion lib/utilities.js
Expand Up @@ -244,8 +244,16 @@ utilities.dispositionRange = function(message) {
* @return {String}
*/
utilities.linkName = function(address, policyOverrides) {
return ((!!policyOverrides && !!policyOverrides.name) ?
var name = ((!!policyOverrides && !!policyOverrides.name) ?
policyOverrides.name : address + '_' + uuid.v4());
if (policyOverrides.hasOwnProperty('attach') &&
policyOverrides.attach.hasOwnProperty('source') &&
policyOverrides.attach.source.hasOwnProperty('dynamic') &&
policyOverrides.attach.source.dynamic === true) {
name = 'dynamic' + name;
}

return name;
};

utilities.camelCase = function(name) {
Expand Down
1 change: 1 addition & 0 deletions package.json
Expand Up @@ -20,6 +20,7 @@
"devDependencies": {
"benchmark": "^2.1.0",
"chai": "^3.5.0",
"chai-string": "^1.2.0",
"istanbul": "^0.4.2",
"jsdoc-to-markdown": "^1.3.3",
"jshint": "^2.9.1",
Expand Down
10 changes: 10 additions & 0 deletions test/integration/qpid/client.test.js
Expand Up @@ -89,6 +89,16 @@ describe('Client', function() {
});
});

it('should append dynamic link names with `dynamic_`', function() {
return test.client.connect(config.address)
.then(function() {
return test.client.createReceiver(null, { attach: { source: { dynamic: true } } });
})
.then(function(receiver) {
expect(receiver.name).to.startWith('dynamic_');
});
});

describe('Messages', function() {
[
{
Expand Down
3 changes: 3 additions & 0 deletions test/integration/qpid/config.js
@@ -1,4 +1,7 @@
'use strict';
var chai = require('chai');
chai.use(require('chai-string'));

module.exports = {
address: (process.env.SERVER ? 'amqp://'+process.env.SERVER : 'amqp://localhost'),
defaultLink: 'amq.topic'
Expand Down

0 comments on commit 69960e0

Please sign in to comment.