fix(sasl): pass errors to callback, don't throw

noodlefrenzy · Oct 20, 2016 · c5b11ee · c5b11ee
1 parent db6295f
commit c5b11ee
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/lib/sasl.js b/lib/sasl.js
@@ -66,8 +66,8 @@ Sasl.prototype._processFrame = function(frame) {
     var mechanisms = Array.isArray(frame.saslServerMechanisms) ?
       frame.saslServerMechanisms.map(function(m) { return m.value; }) : frame.saslServerMechanisms;
     if (!u.includes(mechanisms, mechanism)) {
-      throw new errors.AuthenticationError(
-        'SASL ' + mechanism + ' not supported by remote.');
+      this.callback(new errors.AuthenticationError(
+        'SASL ' + mechanism + ' not supported by remote.'));
     }
     if (mechanism === Sasl.Mechanism.PLAIN) {
       debug('Sending ' + this.credentials.user + ':' + this.credentials.pass);
@@ -82,8 +82,8 @@ Sasl.prototype._processFrame = function(frame) {
       }
       buf.appendUInt8(0); // <null>
     } else {
-      throw new errors.NotImplementedError(
-          'Only SASL PLAIN and ANONYMOUS are supported.');
+      this.callback(new errors.NotImplementedError(
+          'Only SASL PLAIN and ANONYMOUS are supported.'));
     }
     var initFrame = new frames.SaslInitFrame({
       mechanism: mechanism,