fix(longs): temporarily fix encoding longs in master

noodlefrenzy · Feb 16, 2016 · c9e4810 · c9e4810
1 parent 1c3fe4e
commit c9e4810
Show file tree

Hide file tree

Showing 4 changed files with 15 additions and 15 deletions.
diff --git a/lib/types.js b/lib/types.js
@@ -386,7 +386,7 @@ registerType('ulong', {
             bufb.appendUInt32BE(0x0);
             bufb.appendUInt32BE(val);
           } else {
-            throw new errors.NotImplementedError('No int64 Number supported by buffer encoder');
+            bufb.appendBuffer((new Int64(val)).toBuffer());
           }
         }
       },
@@ -433,7 +433,7 @@ registerType('long', {
             bufb.appendUInt32BE(val < 0 ? 0xFFFFFFFF : 0x0);
             bufb.appendUInt32BE(val < 0 ? (0xFFFFFFFF - absval + 1) : absval);
           } else {
-            throw new errors.NotImplementedError('buffer-encoder does not support 64-bit int appending');
+            bufb.appendBuffer((new Int64(val)).toBuffer());
           }
         } else {
           throw new errors.EncodingError('Invalid encoding type for 64-bit value: ' + val);

diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "amqp10",
-  "version": "2.2.2",
+  "version": "2.2.4",
   "description": "Native AMQP-1.0 client for node.js",
   "main": "./lib",
   "engines": {

diff --git a/test/integration/servicebus/eventhubs/client.test.js b/test/integration/servicebus/eventhubs/client.test.js
@@ -29,8 +29,8 @@ describe('ServiceBus', function() {
       test.client.connect(config.address)
         .then(function() {
           return Promise.all(
-            _.range(config.partitionCount).map(function(partition) { return test.client.createReceiver(config.receiverLinkPrefix + partition); }).
-              concat(test.client.createSender(config.senderLink))
+           _.range(config.partitionCount).map(function(partition) { return test.client.createReceiver(config.receiverLinkPrefix + partition); }).
+             concat(test.client.createSender(config.senderLink))
           );
         })
         .then(function (links) {

diff --git a/test/unit/test_types.js b/test/unit/test_types.js
@@ -47,11 +47,11 @@ describe('Types', function() {
     describe('primitives', function() {
       describe('scalar', function() {
         describe('errors', function() {
-          it('should error encoding ulongs greater than 2^32 - 1', function() {
-            var buffer = new BufferBuilder();
-            var type = new ForcedType('ulong', 4294967295);
-            expect(function() { codec.encode(type, buffer); }).to.throw(errors.NotImplementedError);
-          });
+          // it('should error encoding ulongs greater than 2^32 - 1', function() {
+          //   var buffer = new BufferBuilder();
+          //   var type = new ForcedType('ulong', 4294967295);
+          //   expect(function() { codec.encode(type, buffer); }).to.throw(errors.NotImplementedError);
+          // });
 
           it('should error encoding ulongs of invalid type', function() {
             var buffer = new BufferBuilder();
@@ -60,11 +60,11 @@ describe('Types', function() {
           });
 
 
-          it('should error encoding longs greater than 2^32 - 1', function() {
-            var buffer = new BufferBuilder();
-            var type = new ForcedType('long', 4294967295);
-            expect(function() { codec.encode(type, buffer); }).to.throw(errors.NotImplementedError);
-          });
+          // it('should error encoding longs greater than 2^32 - 1', function() {
+          //   var buffer = new BufferBuilder();
+          //   var type = new ForcedType('long', 4294967295);
+          //   expect(function() { codec.encode(type, buffer); }).to.throw(errors.NotImplementedError);
+          // });
 
           it('should error encoding longs of invalid type', function() {
             var buffer = new BufferBuilder();