Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

amqp10@3.3.0 breaks support for x509 certificates #268

Closed
pierreca opened this issue Oct 19, 2016 · 1 comment
Closed

amqp10@3.3.0 breaks support for x509 certificates #268

pierreca opened this issue Oct 19, 2016 · 1 comment

Comments

@pierreca
Copy link
Collaborator

This change: d067202

uses deepMerge but deepMerge doesn't support duplicating objects of type Buffer, which are used to store certificates and keys in the sslOptions field (Buffer constructors require arguments, and
https://github.com/noodlefrenzy/node-amqp10/blob/master/lib/utilities.js#L120 will not pass them).
@dnwe
Copy link
Contributor

dnwe commented Oct 20, 2016

@mbroadst oops. As this is a breaking regression, should we be pushing out a 3.3.1?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pierreca @dnwe