integrate pacemaker-remote #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
_pacemaker_corosync_bind_addr was only generating the ip address of the current node and so on all nodes you got the same ip address.
|
Sorry, I totally missed this PR :( |
| @@ -1,4 +1,9 @@ | |||
| {% set _pacemaker_corosync_bind_addr = hostvars[inventory_hostname]['ansible_' + pacemaker_corosync_ring_interface | replace('-', '_')].ipv4.address %} | |||
| {% if inventory_hostname in groups[pacemaker_corosync_group] %} | |||
There was a problem hiding this comment.
However this change does not make much sense to me, and I guess I need to revert it. Why you should be obliged to use eth1 interface for pacemaker_corosync_group? I think that user should leverage either group_vars or another variable should be added to control interface for different groups.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_pacemaker_corosync_bind_addr was only generating the ip address of the current node and so on all nodes you got the same ip address.