Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add reorg test for IndexFilterBuilder #51

Closed
nopara73 opened this issue Mar 5, 2018 · 1 comment
Closed

Add reorg test for IndexFilterBuilder #51

nopara73 opened this issue Mar 5, 2018 · 1 comment
Assignees
@lontivero

Comments

@nopara73
Copy link
Owner

nopara73 commented Mar 5, 2018

I added Nicolas's NodeBuilder (the one that's used in NTumbleBit, so it works on Linux and Windows) and I added some basic tests for the IndexFilterBuidler:

dc5d694#diff-4b985814ee76663ced0a1d3899107e09R202

More tests are appreciated, especially a reorg test. I can test it with regtest rpc's invalidateblock, so I made sure reorgs work properly, yet unit test may be also needed here for further code changes.

Reorgs will work properly after this PR is merged, now they only half working: #48
@nopara73 nopara73 mentioned this issue Mar 6, 2018
Closed
@nopara73
Copy link
Owner Author

Thi is half done. Other half in different issue: #68

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lontivero lontivero

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lontivero @nopara73