Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Main partial title not always applied to navigation dropdown #7

Closed
paul66 opened this issue Oct 25, 2013 · 1 comment
Closed

Main partial title not always applied to navigation dropdown #7

paul66 opened this issue Oct 25, 2013 · 1 comment
Labels

Comments

@paul66
Copy link
Contributor

paul66 commented Oct 25, 2013

The first comment block in the Sass partial is used to denote the <h1> for the style guide page.

If a blank line is added after the opening comment block like so...

/*

My Module
=========
*/

...then the <h1> title is used in the dropdown navigation rather than the Sass partial name i.e. My Module appears in the navigation rather than _my-module.

However if that extra blank line is not added after the opening comment block e.g.

/*
My Module
=========
*/

then the Sass partial name is not replaced by this title and remains as the Sass partial name.

I think zero, one or many blank lines should be permissible in the opening comment block before the title.

@winstromming
Copy link
Owner

Fixed in 3be06c8.

Have amended the pattern matching to parse headings post-Markdown. Following cases have been tested and found to output properly both in-page and in-navigation:

"Setext" style syntax

/*

My Module
=========

*/
/*
My Module
=========
*/
/* My Module
========= */

"atx" style syntax

/*

# My Module

*/
/*
# My Module
*/
/* # My Module */

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants