Missing page to handle self generated reset-password link #564
Comments
sunapi386
added a commit
to sunapi386/fancystack
that referenced
this issue
May 1, 2020
- The base repo did not handle reset password links. So I made a page to handle it, and added to the router path. - The base repo's reset link worked for up to 4w and worked multiple times. So I made the link expire in 1d, and used the user's current password's hash for signing the JWT token, in this way all tokens generated before a successful password change would get invalidated the next time. - The base repo's reset entity did not hash the user's password upon insert, so I annotated the hashing with `@BeforeUpdate()` Accepting this PR closes NoQuarterTeam#564
sunapi386
added a commit
to sunapi386/fancystack
that referenced
this issue
Jun 28, 2020
- The base repo did not handle reset password links. So I made a page to handle it, and added to the router path. - The base repo's reset link worked for up to 4w and worked multiple times. So I made the link expire in 1d, and used the user's current password's hash for signing the JWT token, in this way all tokens generated before a successful password change would get invalidated the next time. - The base repo's reset entity did not hash the user's password upon insert, so I annotated the hashing with `@BeforeUpdate()` Accepting this PR closes NoQuarterTeam#564 - Rebased from master
sunapi386
added a commit
to sunapi386/fancystack
that referenced
this issue
Jun 28, 2020
- The base repo did not handle reset password links. So I made a page to handle it, and added to the router path. - The base repo's reset link worked for up to 4w and worked multiple times. So I made the link expire in 1d, and used the user's current password's hash for signing the JWT token, in this way all tokens generated before a successful password change would get invalidated the next time. - The base repo's reset entity did not hash the user's password upon insert, so I annotated the hashing with `@BeforeUpdate()` Accepting this PR closes NoQuarterTeam#564 - Rebased from master (Jun 27)
|
New release has this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This link this is not handled by the CheckAuth router.
I see the api exists in
user.resolver.tsso maybe this page was forgotten to be added. I could create a PR for my version of this page or you guys can add it.The text was updated successfully, but these errors were encountered: