-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
null ref exception thrown when displayname and/or username are not provided #9
Comments
Please do a pull request
…On Wed, Oct 10, 2018, 10:35 PM AdamDurani ***@***.***> wrote:
I have a fix on a local branch, can i have access to create a branch?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#9>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAbQbA2s2preJy3BgdT_ttZ3-YiaC3C4ks5ujfe7gaJpZM4XVWkX>
.
|
I need access to PR.
From: Nordes Ménard-Lamarre <notifications@github.com>
Sent: 11 October 2018 13:07
To: Nordes/IdentityServer4.LdapExtension <IdentityServer4.LdapExtension@noreply.github.com>
Cc: Adam Durani <Adam.Durani@tombola.com>; Author <author@noreply.github.com>
Subject: Re: [Nordes/IdentityServer4.LdapExtension] null ref exception thrown when displayname and/or username are not provided (#9)
Please do a pull request
On Wed, Oct 10, 2018, 10:35 PM AdamDurani ***@***.******@***.***>> wrote:
I have a fix on a local branch, can i have access to create a branch?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#9>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAbQbA2s2preJy3BgdT_ttZ3-YiaC3C4ks5ujfe7gaJpZM4XVWkX>
.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub<#9 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/ApC8YPnni2AVPMSEvNLoTxae4tmh9Q9Yks5ujzRMgaJpZM4XVWkX>.
…--
______________________________________________________________________
This email has been scanned for malware by Sophos UTM 9.
______________________________________________________________________
|
Sorry for late reply, Pull requests can be done from your own repository. You first need to fork, then be on the latest version + do your changes and then pull... normally it will shows into the pull request list. |
Please, also give a full detail for your user properties. A user without a username is a bit problematic ;). I will require the steps to reproduce locally. Thank you. |
FYI: I received pullrequest from peoeple who don't have any access. |
I just ran into this very thing after spending many hours thinking I was screwing up the appsettings configuration. The bug is in the The steps to reproduce for me were:
I have not created a PR on github in the past but I can look at doing so. |
Note: My PR does not handle |
I have same problem. @Nordes Please fix it. |
Should now be available through Nuget. |
I have a fix on a local branch, can i have access to create a branch?
The text was updated successfully, but these errors were encountered: