Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conflict in READMEmd - Building image locally: nrf-docker vs nrfconnect-skd #3

Closed
timov50 opened this issue May 20, 2022 · 1 comment

Comments

@timov50
Copy link

timov50 commented May 20, 2022

The paragraph Building image locally at moment:

Clone the repo:

git clone https://github.com/NordicPlayground/nrf-docker

Build the image (this is only needed once):

cd nrfconnect-sdk
docker build -t nrfconnect-sdk --build-arg sdk_nrf_revision=v1.9-branch .

My assumption is that the above lines should be
cd nrf-docker
docker build -t nrfconnect-sdk --build-arg sdk_nrf_revision=v1.9-branch .

Similar conflict in the Full example.
# build docker image
git clone https://github.com/NordicPlayground/nrf-docker
cd nrfconnect-sdk
docker build -t nrfconnect-sdk --build-arg sdk_nrf_revision=v1.9-branch .
cd ..

@coderbyheart
Copy link
Member

Thanks for catching this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants