Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

async api #19

Closed
dandyhuang opened this issue Jan 11, 2021 · 2 comments
Closed

async api #19

dandyhuang opened this issue Jan 11, 2021 · 2 comments

Comments

@dandyhuang
Copy link

Will it block when the cluster node connection fails?

@bjosv
Copy link
Collaborator

bjosv commented Jan 25, 2021

The current behavior has currently not changed compared to hiredis-vip.
When a connection to a cluster node gets disconnected the registered event system will receive a disconnect event.
Then after the user has done configured max_redirect _count attempts to reach this node (+ a timer..) there will be an update of the slots/nodes routing table using any node.
This update will trigger an attempt to connect to the chosen node, but as it is now, this is not done in a non-block fashion..
If a timeout has been configured this will avoid a longer block, but still, it is not using the non-block connect API in hiredis..
This needs to be fixed.
Another improvement would be to use an already connected node for updating the slots/route info.

Please comment if this was the right scenario. Sorry for the late response.

@bjosv
Copy link
Collaborator

bjosv commented Apr 27, 2023

This behavior was corrected in #144.

@bjosv bjosv closed this as completed Apr 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants