Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve watch function to support more properties in the filter #295

Open
LionelJouin opened this issue Sep 22, 2022 · 0 comments
Open

Improve watch function to support more properties in the filter #295

LionelJouin opened this issue Sep 22, 2022 · 0 comments

Comments

@LionelJouin
Copy link
Member

Is your feature request related to a problem? Please describe.
The "Watch" functions in the API takes an object as parameter which will be used to filter the returned list of object by server. Currently, all filters are using the the name and the parent (name of parent), other properties must be also considered.

Describe the solution you'd like
Other properties must be also considered. It should be possible to filter on any property. For example, it should be possible to pass the protocol, src port/IP to find every flow that correspond to these properties (the src IP should be in the range one of the src CIDR).

Describe alternatives you've considered
/

Additional context
Filters are mostly defined by the Equals/Filter functions:
https://github.com/Nordix/Meridio/blob/master/api/nsp/v1/utils.go
https://github.com/Nordix/Meridio/blob/v0.8.0/api/ambassador/v1/filter.go
This should be also redefined/refactored to have a good code base and good function name.

Adding other properties changes the behavior of the watch functions, so it might break clients if they pass other properties (since for now these properties are ignored). Each client should be carefully verified and refactored to remove other extra unsed properties.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 📋 To Do
Development

No branches or pull requests

1 participant