Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TAPA v0.9.0 gets 0 as max-target if used with NSP <= v0.8.0 #323

Closed
LionelJouin opened this issue Nov 22, 2022 · 1 comment
Closed

TAPA v0.9.0 gets 0 as max-target if used with NSP <= v0.8.0 #323

LionelJouin opened this issue Nov 22, 2022 · 1 comment

Comments

@LionelJouin
Copy link
Member

Describe the bug
Since the NSP v0.8.0 doesn't know about the max-target field in the stream (introduced in v0.9.0), it sends the stream without that field. TAPA v0.9.0 knows about this max-target, and if no value is set, then 0 is used by default.

To Reproduce

  • Deploy Meridio v0.8.0
  • Deploy TAPA v0.9.0

Expected behavior
100 must be used as default value if the max-target field sent by the NSP is empty.

Context

  • Meridio: v0.0.0
  • TAPA: v0.9.0

Logs

{"severity":"info","timestamp":"2022-11-22T15:39:18.75+00:00","service_id":"Meridio-tapa","message":"Attempt to open stream","version":"1.0.0","extra_data":{"class":"Stream","stream":"name:\"stream-1\" conduit:{name:\"lb-fe-a\" trench:{name:\"trench-a\"}}"}}
{"severity":"error","timestamp":"2022-11-22T15:39:18.757+00:00","service_id":"Meridio-tapa","message":"opening stream","version":"1.0.0","extra_data":{"stream":"name:\"stream-1\" conduit:{name:\"lb-fe-a\" trench:{name:\"trench-a\"}}","error":"no identifier available to register the target"}}
@LionelJouin
Copy link
Member Author

LionelJouin commented Nov 22, 2022

Fix: #324

@LionelJouin LionelJouin changed the title TAPA v0.9.0 gets 0 as max-target if used with NSP v0.8.0 TAPA v0.9.0 gets 0 as max-target if used with NSP <=0 v0.8.0 Nov 22, 2022
@LionelJouin LionelJouin changed the title TAPA v0.9.0 gets 0 as max-target if used with NSP <=0 v0.8.0 TAPA v0.9.0 gets 0 as max-target if used with NSP <= v0.8.0 Nov 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

No branches or pull requests

1 participant