fix: update font sizes #625
Conversation
mjmonline
requested review from
iamstarkov,
Dhq,
shmidt-i,
robineng,
jesperwiner,
KitsuneKelso,
JacobBlomgren and
jauniuse
|
This pull request is automatically deployed with Now. Latest deployment for this branch: https://nordnet-ui-kit-git-fix-typography-font-size-update.nordnet1.now.sh |
|
Please don't merge this branch yet |
src/styles/typography.js
Outdated
| @@ -17,16 +17,16 @@ export default function createTypography() { | |||
| }, | |||
| }); | |||
| const primary = ({ weight = 'regular' } = {}) => ({ | |||
| ...ifSmallDevice(14, 16), | |||
| ...ifSmallDevice(16, 16), | |||
There was a problem hiding this comment.
does it make sense to have a function then? I mean it includes media query, so that will be included in all primary texts
There was a problem hiding this comment.
and perhaps will slow down the paint/draw/layout events
There was a problem hiding this comment.
Good remarks, fixed
Codecov Report
@@ Coverage Diff @@
## master #625 +/- ##
==========================================
+ Coverage 84.01% 84.03% +0.02%
==========================================
Files 213 213
Lines 1558 1560 +2
Branches 296 296
==========================================
+ Hits 1309 1311 +2
Misses 214 214
Partials 35 35 |
| fontSize: smallFontSize, | ||
| letterSpacing: 'normal', | ||
| [`@media only screen and (min-width: ${SMALL_DEVICE}px)`]: { |
There was a problem hiding this comment.
SMALL_DEVICE is still 360 here, need to change to 480
|
🎉 This PR is included in version 5.3.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Updated font sizes according to design