Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comments unreadable on VCS diffs #164

Open
bendardenne opened this issue Oct 23, 2020 · 2 comments
Open

Comments unreadable on VCS diffs #164

bendardenne opened this issue Oct 23, 2020 · 2 comments

Comments

@bendardenne
Copy link

The background color for added lines in a version control diff makes it hard to read comments.

Screenshot from 2020-10-23 13-22-29

@arcticicestudio
Copy link
Contributor

Hi @bendardenne 👋, thanks for your contribution 👍

It looks like you're using a outdated version of the Nord plugin. The colors from your screenshot are related to PR #25 which reduced the alpha layer value, but was not working well with comments, so in #159 the colors were changed to match the ones also used in the Nord Visual Studio Code port project. The change was shipped with the Nord plugin version 0.12.0.

❗ Please also note that modifying editor schemes of plugins will create a copy of the scheme that is placed in the colors folder within your default IDE configuration directory directory and that this copy won't be updated when the plugin gets updated.
Unfortunately JetBrains hasn't solved this "problem" which often caused false-positive issues in theme repositories regarding "non-working theme plugins" or "outdated styles".
In order to update your copy you either need to manually edit the theme files and add changes made to the plugin or delete the copy and re-create it with you custom style based on the latest plugin version. You can export your customized theme as XML file or dedicated theme plugin to backup your changes later on and when updating to later Nord plugin versions later on.

Can you please make sure that you're running the currently latest Nord plugin version and you're not using a customized editor scheme by checking the content of your colors folder?

@KTibow
Copy link

KTibow commented May 13, 2023

Can this be closed as stale?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants