Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Copy Mode Screenshot Incorrect #9

Closed
tsroten opened this issue Jul 12, 2017 · 4 comments
Closed

Copy Mode Screenshot Incorrect #9

tsroten opened this issue Jul 12, 2017 · 4 comments
Labels
resolution-superseded

Comments

@tsroten
Copy link
Contributor

tsroten commented Jul 12, 2017

It looks like the screenshot in the README for copy mode actually has the colors inverted when you compare it to nord.conf.

I'm not sure which one was the intention -- to match the prefix highlight like the screenshot, or to make it distinguishable from the prefix highlight like the source file.
@arcticicestudio
Copy link
Contributor

The screenshot and color definitions are correct, the colors are switched for the status bar integration, otherwise the arrow () would be colorized black.

gh-9-scrot-color-switch

@tsroten
Copy link
Contributor Author

tsroten commented Jul 17, 2017

Ah, yes, I see. Thanks for the clarification!

So, when the status content is turned off, the colors for the copy mode indicator are inverted. I'll try to submit a pull request to fix that.

@arcticicestudio
Copy link
Contributor

This has been resolved in #11 which splitted the definition for the copy-mode indicator into separate files based on the user configuration.

@arcticicestudio
Copy link
Contributor

Superseded by #11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
resolution-superseded
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tsroten @arcticicestudio