-
-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kill signal for server process in loop
#31
Comments
loop
@peterbecich Feedback was never really intended for long-running processes in the loop, but now I see that that's actually a really cool use-case. I think your before-all hook would not really solve the issue at hand. Feedback "just" needs to wait for the process to exit correctly, but I'm surprised that it doesn't because I thought I had implemented that :( Any digging would be welcome because I'm currently at an airport. |
@peterbecich any news? |
@NorfairKing , no, sorry, I've been unable to put any time into this issue |
@peterbecich have you tried with latest master? It might be fixed now. I added some smartness about killing the loop process. |
Thanks for this great program.
I have a
feedback.yaml
, and have defined aloop
: https://github.com/peterbecich/halogen-chess/blob/8ec3f53991e529b44b5bfd78889e0fa91f4b6a93/feedback.yaml#L15It runs a program
halogen-chess
which binds to port 8080.The
loop
runs once successfully.When the
loop
restarts, I see an error:The issue is solved by exiting
feedback
, which kills thehalogen-chess
process bound to port 8080.Could
feedback
send a different kill signal to the process, when theloop
is repeated, to solve this issue?An alternative solution may be a
before-all
hook
, such as:The text was updated successfully, but these errors were encountered: