Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for RTL #88

Closed
jeev1989 opened this issue Jul 31, 2023 · 6 comments · Fixed by #96
Closed

Support for RTL #88

jeev1989 opened this issue Jul 31, 2023 · 6 comments · Fixed by #96

Comments

@jeev1989
Copy link

Describe the bug
On RTL looks like the initial focus on the swimlane is not being picked properly, also key navigation which needs to be reveresed.

To Reproduce
Steps to reproduce the behavior:

  1. Load the demo app, change the body dir to rtl
  2. navigate left from the menu to bring the focus on the swimlanes
  3. Observe the current focused element, this is not the expected element

Expected behavior
Focused element is the 7th item(sn:focusable-item-28) in the swimlane, where as it should have been the first.

Screenshots
Screenshot 2023-07-31 at 5 47 42 PM

Additional context
Is RTL support expected/planned for this library? It would be a good feature if it supports RTL on the fly.

@jeev1989
Copy link
Author

@asgvard @zemlanin @eigil @hans00 : Can anybody please let me know if you guys are aware of such an issue?

@sarah-harissa-dotcom
Copy link

There are issues on RTL, is there a way to fix it?

@jeev1989
Copy link
Author

Add support for RTL #96 seems to be working as expected as per the issue reported by me.
Kindly request @asgvard @zemlanin @eigil @hans00 to checkout the PR and update if changes are good.

@Braggiouy Braggiouy linked a pull request Nov 14, 2023 that will close this issue
@Braggiouy
Copy link
Contributor

Status Update:

The pull request Add support for RTL has been approved. It will be incorporated into the upcoming release, effectively addressing the associated issue.

@sarah-harissa-dotcom
Copy link

sarah-harissa-dotcom commented Nov 15, 2023 via email

@jeev1989
Copy link
Author

Thanks alot guys..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants