New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Also support django_prpmetheus wrapped caches #167
Conversation
7 similar comments
@Natureshadow I'm planning on removing those databases in the next release. You can add support yourself by adding in your settings: https://django-cachalot.readthedocs.io/en/latest/quickstart.html#cachalot-databases |
So, what does this mean for supporting the cache backends?
|
Most important thing: django-cachalot/cachalot/apps.py Lines 25 to 36 in d0b5213
So even if your cache is configured as: CACHES = {
"default": {"BACKEND": "whatever"}
} Django only raises a warning, and you can mute the warning. Unlike the databases setting, this one will not raise an error, only a warning which can be muted in your settings.We use Django's regular from django.core.cache import cache
cache.get("key") and the regular basic ones found in BaseCache, then cachalot should support it. I believe, IIRC, we only use |
Great, thanks! |
Description
Add the cache backends wrapped by django_prometheus as supported backends.
Rationale
cachalot already explicitly supports django_prometheus' wrappers for database backends. djanfo_prometheus does the same wrapping for cache backends, so they should be supported as well.