Prefer plaintext over html of all the mail multiparts #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HoverHell
referenced
this pull request
in HoverHell/mail-transport
Dec 24, 2014
|
I've found another problem: the last part of a multipart message was ignored. A bunch of tweaking and cleaning and stuff after, this is okay to merge now. I'm planning on making an IMAP(+IDLE)&SSMTP version of this transport later (and maybe a jabber-bot option) so it requires less infrastructure to use. |
normanr
added a commit
that referenced
this pull request
Jan 26, 2015
html2text, logging, multipart processing fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Configurable.
I had my suspicions, but only found examples today: sometimes, the text/plain part of the message is worse (less useful/informative/readable) than html2text'd version of the html part of the message. The example I found has the text/plain part contain the same html as the html part, except it, of course, doesn't get processed with html2text.