Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shortcuts Assignment Consistency Update #79

Open
1 of 7 tasks
joshuajames-smith opened this issue Feb 3, 2022 · 0 comments
Open
1 of 7 tasks

Shortcuts Assignment Consistency Update #79

joshuajames-smith opened this issue Feb 3, 2022 · 0 comments
Labels
ANNOTATE [Product] Relating to the ANNOTATE platform. AUDIT [Product] Relating to the AUDIT platform. CURATE [Product] Relating to the CURATE platform. DOCUMENT [Product] Relating to the DOCUMENT platform. MANAGE [Product] Relating to the MANAGE platform. STYLE [Product] Relating to the STYLE platform.

Comments

@joshuajames-smith
Copy link
Contributor

joshuajames-smith commented Feb 3, 2022

Problem

There is an inconsistency with how we handle shortcut assignment and display shortcuts in tooltips which should be improved to give a useable, consistent UX. https://github.com/gliff-ai/annotate/pull/415 handle implementing an update towards this feature, but some tools have a shortcut assignment but do not display shortcuts in their corresponding tooltips. Examples below:

Screenshot 2022-02-03 at 14 10 19 Screenshot 2022-02-03 at 14 13 52
Screenshot 2022-02-03 at 14 14 38 Screenshot 2022-02-03 at 14 26 04

Similarly, the shortcut dialogue menu is currently an undesigned list with no easy way to access (it seems to only appear when the platform is used on a tablet device?). So this also requires a design to match the UI and improve the UX.

Solution

Below is a list of issues created in each repo for implementation in order of what the process order may be best:

Closes https://github.com/gliff-ai/annotate/issues/421.

Considered Alternatives

N/A

Additional Context

In the future, we may want to expand on this to offer touchscreen / tablet interactions. Adobe Fresco is a good point of reference for this.

Further reading:
https://knock.app/blog/how-to-design-great-keyboard-shortcuts
https://w3c.github.io/aria-practices/#keyboard

@joshuajames-smith joshuajames-smith added ANNOTATE [Product] Relating to the ANNOTATE platform. CURATE [Product] Relating to the CURATE platform. MANAGE [Product] Relating to the MANAGE platform. AUDIT [Product] Relating to the AUDIT platform. STYLE [Product] Relating to the STYLE platform. DOCUMENT [Product] Relating to the DOCUMENT platform. labels Feb 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ANNOTATE [Product] Relating to the ANNOTATE platform. AUDIT [Product] Relating to the AUDIT platform. CURATE [Product] Relating to the CURATE platform. DOCUMENT [Product] Relating to the DOCUMENT platform. MANAGE [Product] Relating to the MANAGE platform. STYLE [Product] Relating to the STYLE platform.
Projects
None yet
Development

No branches or pull requests

1 participant