Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

closure_uid keeps showing up in props created by goog.object #2

Closed
lilactown opened this issue Jun 13, 2018 · 7 comments
Closed

closure_uid keeps showing up in props created by goog.object #2

lilactown opened this issue Jun 13, 2018 · 7 comments
Labels
bug Something isn't working compiler

Comments

@lilactown
Copy link
Collaborator

No description provided.

@lilactown lilactown added bug Something isn't working compiler labels Jun 13, 2018
@pepe
Copy link

pepe commented Nov 1, 2018

Sorry, I just found out, you are in the process of quite big refactoring. You can ignore this comment.

Hi. I am seeing it also. Do you think it can force to update components, even if the rendered DOM has not changed?

@lilactown
Copy link
Collaborator Author

😅 thanks for commenting though. Yeah, hoping to solve this in the refactoring.

@lilactown lilactown reopened this Nov 1, 2018
@lilactown
Copy link
Collaborator Author

It looks like this was fixed in the refactoring I've done

@pepe
Copy link

pepe commented Nov 5, 2018

It indeed was for me. Actually I am liking this library more and more. I event did some example project with it: hxor. It is right for usage with shadow-cljs.

Thanks man!

@lilactown
Copy link
Collaborator Author

Great! 😄 There are still a few things that I feel like I need to get right with it, but I'm glad you are enjoying it!

I took a look at your example project. I'd never heard of funcool/potok. It's pretty cool!

I noticed that you're calling hiccup/parse a couple times in component.cljs. Specifically here:

https://github.com/pepe/hxor/blob/master/src/hxor/components.cljs#L12

https://github.com/pepe/hxor/blob/master/src/hxor/components.cljs#L22

https://github.com/pepe/hxor/blob/master/src/hxor/components.cljs#L32

Those should not be necessary 😉. As long as the vectors are realized at runtime in the return value of defnc, then they will be interpreted correctly.

If that's not clear from the docs (or that actually isn't working), feel free to open up another issue!

@pepe
Copy link

pepe commented Nov 6, 2018

Great! Thank you very much. I will fix it.

Potok is in my opinion the best way to handle the state of the app. And Beicon (RxJS wrapper in cljs, on which Potok is based) is of similar idea as hx, I believe.

@pepe
Copy link

pepe commented Nov 7, 2018

It's fixed in hxor, thank you again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working compiler
Projects
None yet
Development

No branches or pull requests

2 participants