Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for stones (mass) #22

Open
dominic-ks opened this issue Feb 18, 2021 · 3 comments
Open

Support for stones (mass) #22

dominic-ks opened this issue Feb 18, 2021 · 3 comments

Comments

@dominic-ks
Copy link

Hello,

Is there the possibility to add support for stones in mass, or perhaps a way to easily extend the functions to add any units that are not supported?

Thanks,

@dominic-ks
Copy link
Author

Or of course I can contribute this if it's welcome:

@nosferatoy
Copy link
Owner

Tnx, I will review the PR in depth later (the code addition is simple) but I am not sure if stones are a proper unit for the imperial system or I have to expand the library so it can accommodate 'historical'(?) units.

Also about the contributions, I am interested to build a proper community to maintain this library but I have to make some improvements to my pipeline for building and npm deployment first.

@dominic-ks
Copy link
Author

Hello, stones are definitely a proper imperial unit, and not historical in the UK at least... The standard units for measuring a person's weight, for example, is stones / pounds.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants