Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redmine 4.1 Compatibility #57

Closed
dktcoding opened this issue Dec 23, 2019 · 5 comments
Closed

Redmine 4.1 Compatibility #57

dktcoding opened this issue Dec 23, 2019 · 5 comments
Assignees

Comments

@dktcoding
Copy link
Contributor

@dktcoding dktcoding commented Dec 23, 2019

Hi there!

I was testing Redmine 4.1 and found that vault fails with Internal error, upon closer inspection found this in the log:

ActionView::Template::Error (wrong number of arguments (given 1, expected 0)):
    78: <% if Redmine::VERSION.to_s.start_with?('3.4') or Redmine::VERSION.to_s.start_with?('4.0')  %>
    79:     <%= context_menu %>
    80: <% else %>
    81:     <%= context_menu project_keys_context_menus_path(@project) %>
    82: <% end %>
    83:
    84: <script type="text/javascript">

Regards

@dktcoding
Copy link
Contributor Author

@dktcoding dktcoding commented Dec 23, 2019

BTW replacing line 78 for:

<% if Redmine::VERSION.to_s.start_with?('3.4', '4.0', '4.1')  %>

Seems to work fine

@noshutdown-ru-user
Copy link
Member

@noshutdown-ru-user noshutdown-ru-user commented Dec 23, 2019

Thx for info will take a look

@noshutdown-ru-user
Copy link
Member

@noshutdown-ru-user noshutdown-ru-user commented Jan 4, 2020

implemented in 0.4.1 version

@mtolava
Copy link

@mtolava mtolava commented Apr 13, 2021

add '4.2' in the line 78 resolve compatibility with redmine 4.2

<% if Redmine::VERSION.to_s.start_with?('3.4', '4.0', '4.1',4.2) %>

@noshutdown-ru-user
Copy link
Member

@noshutdown-ru-user noshutdown-ru-user commented Apr 14, 2021

thx for report

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants