Clarify numeralIntegerScale

[adnasa]

Hey @nosir,
thanks for this project.

---

You ought to clarify what numeralIntegerScale entails in the docs, would have especially helpful if your releases included a breaking change section

In one project, we found out that this has affected all numerical values (including inputs which represented a money value such as a price of a product) of our app, where the value exceeded the length of 10 (default value to numeralIntegerScale)

ref: #196

[nosir]

Hey, do you mean this? https://github.com/nosir/cleave.js/blob/master/doc/options.md#numeralintegerscale

But I agree, 10 is not an ideal default value, will change to make it backward compatible

[adnasa]

yes, that is the option I was referring to.

possible solution:
either that, or you have it disabled when no value is given upon mount.

[tdeekens]

I would disable defaulting to any numeral integer scale as it might confuse people. Whenever they opt into it, it's an explicit choice.

[nosir]

Okay, will fix.

[adnasa]

@nosir with the upcoming fix, will it be compatible with numeralIntegerScale: 0 for disabled?
at the moment we set numeralIntegerScale to 0 to disable it

[nosir]

Yes, either 0 or no value is given will disable the integer scale, so it will be fine in your case.

[adnasa]

perfect, @nosir 👌🏽
I like this.
looking forward to your update

[nosir]

Hi guys, fix released:
https://github.com/nosir/cleave.js/releases/tag/v0.9.0
Cheers

[tdeekens]

Thanks a lot!

[adnasa]

thanks @nosir 👌🏾