Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attributes on non-native wearables stack #30

Closed
nosoop opened this issue Aug 17, 2021 · 7 comments
Closed

Attributes on non-native wearables stack #30

nosoop opened this issue Aug 17, 2021 · 7 comments

Comments

@nosoop
Copy link
Owner

nosoop commented Aug 17, 2021

Separated out individual issue from #28, CC @SnowySnowtime

I'm almost certain this stems from wearables still being on the player. cwx/item_entity.sp::TF2_RemoveItemByLoadoutSlot() only checks against the loadout entity, which means off-class loadouts aren't recognized or unequiped.

I thought I had an issue tracking this quirk somewhere in tf2utils. There's a change there I've been meaning to push, so I'll test / deploy it if it works out.

@nosoop nosoop closed this as completed in 1af55cd Aug 17, 2021
@nosoop
Copy link
Owner Author

nosoop commented Aug 17, 2021

Ended up deciding not to do any changes to tf2utils for the time being.

@SnowySnowtime
Copy link

SnowySnowtime commented Aug 18, 2021

tf_speakeasyinspired_weapons.txt

Example Config, for the issue mentioned above. It makes use of a tf_wearable, which I wanted to have as a stand-in to the Mantreads for visibility sake.

@nosoop
Copy link
Owner Author

nosoop commented Aug 18, 2021

Ah, that's an invalid combination — the item it's inheriting is strictly a wearable and not a wearable weapon like the Gunboats / Mantreads are (see the item slot column).

That's something I'll have to error out on, and to figure out in what way to do that.

There might be a way to implement that correctly in the future, though I can't really guarantee it.

@nosoop
Copy link
Owner Author

nosoop commented Aug 18, 2021

Thanks for the config though; it provides an insight into the sort of creative ways that can break the plugin.

@nosoop
Copy link
Owner Author

nosoop commented Feb 17, 2022

Persistence improvements were made for off-class items, and a side effect of that appears to allow for wearables in non-native slots. I tested your config again and it appears to work.

If you're still using the plugin, do try it and let me know!

@SnowySnowtime
Copy link

I'll try it out!

@SnowySnowtime
Copy link

It works, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants