Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make ActivityType implementations follow a conformal API #24

Closed
jshook opened this issue Feb 26, 2020 · 1 comment
Closed

Make ActivityType implementations follow a conformal API #24

jshook opened this issue Feb 26, 2020 · 1 comment

Comments

@jshook
Copy link
Contributor

jshook commented Feb 26, 2020

Some conventions of ActivityType design have become evident enough in practice to now hoist some patters into the framework level. This will have multiple benefits:

  • Standardize on the conceptual and mechanical patterns needed to implement a well-defined ActivityType.
  • Make the contract between the engine and the activity types more explicit.
  • Allow for higher reuse and generally higher quality of the core components that ActivityType implementations may depend on.

Originally filed as engineblock/engineblock#86
This was referenced Feb 26, 2020
Closed
Open
@jshook jshook added the NEEDS REVIEW All issues are being reviewed to update the plan for NB label Feb 9, 2022
@jshook jshook removed the NEEDS REVIEW All issues are being reviewed to update the plan for NB label Dec 14, 2023
@jshook
Copy link
Contributor Author

jshook commented Dec 14, 2023

subsumed by 5.21 changes

@jshook jshook closed this as completed Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jshook