This repository has been archived by the owner on Nov 4, 2021. It is now read-only.

Font Size Keyboard Shortcut no longer works in 4.x #61

Open

abobwhite opened this issue Jan 29, 2018 · 2 comments

Contributor

abobwhite commented Jan 29, 2018

It appears with the new event data, the "," and "." checks here:
https://github.com/nossas/slate-editor/blob/develop/src/package/plugins/slate-font-size-plugin/FontSizeKeyboardShortcut.js#L10
https://github.com/nossas/slate-editor/blob/develop/src/package/plugins/slate-font-size-plugin/FontSizeKeyboardShortcut.js#L11

no longer work. Instead of "," and ".", it should be "<" and ">"

abobwhite changed the title ~~Font Size Keyboard No longer works in 4.x~~ Font Size Keyboard Shortcut no longer works in 4.x

Contributor

gabrielrtakeda commented Mar 9, 2018 •

edited

Hi @abobwhite!
On which OS is this happening?
I have tested with MacOS in the example URL and it works with:

cmd + shift + , (decrease)
cmd + shift + . (increase)

https://slate-editor.bonde.org/

Contributor Author

abobwhite commented Mar 9, 2018

Hey @gabrielrtakeda I am using on Windows.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.