Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

npm run build script doesn't work because of storybook typo #91

Closed
evaporei opened this issue Dec 7, 2018 · 1 comment
Closed

npm run build script doesn't work because of storybook typo #91

evaporei opened this issue Dec 7, 2018 · 1 comment
Labels
wontfix This will not be worked on

Comments

@evaporei
Copy link
Contributor

evaporei commented Dec 7, 2018

The command npm run build doesn't work because of a typo on package.json.

This:

    "build": "npm run build:clean && npm run build:stylelint && npm run build:sass && npm run build:autoprefix && npm run build:cleancss && npm run build-storybook",

Should be this

    "build": "npm run build:clean && npm run build:stylelint && npm run build:sass && npm run build:autoprefix && npm run build:cleancss && npm run build:storybook",

The name of the storybook build script is build:storybook, and it is build-storybook, which makes the npm run build fail.

screenshot-error-example
@evaporei evaporei mentioned this issue Dec 7, 2018
Closed
@evaporei evaporei changed the title npm build script doesn't work because of storybook typo npm run build script doesn't work because of storybook typo Dec 7, 2018
@evaporei evaporei mentioned this issue Dec 7, 2018
Merged
@trezy trezy added the invalid label Dec 7, 2018
@trezy
Copy link
Member

trezy commented Dec 7, 2018

Marked as invalid since it's already fixed.

@trezy trezy closed this as completed Dec 7, 2018
@trezy trezy added wontfix This will not be worked on and removed invalid labels Dec 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
wontfix This will not be worked on
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@trezy @evaporei