Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Javascript issue with Nosto disabled #16

Closed
pivulic opened this issue Apr 4, 2016 · 1 comment
Closed

Javascript issue with Nosto disabled #16

pivulic opened this issue Apr 4, 2016 · 1 comment
Assignees
@fairlane
Labels
bug
Milestone
1.0-RC2

Comments

@pivulic
Copy link

pivulic commented Apr 4, 2016

Problem

See http://www.vaimo.com/snaps/pablo.ivulic/nosto-js-issue-m2.png where it fails to load the resource.

Expected result

The error message should not be thrown, even if Nosto has not yet been configured.

How to recreate

  1. Install Nosto module
  2. Don't enable it in Magento Admin
  3. Check the javascript console on the frontend
@fairlane fairlane added this to the 1.0-RC2 milestone Apr 4, 2016
@fairlane fairlane self-assigned this Apr 4, 2016
@fairlane fairlane added the bug label Apr 4, 2016
fairlane pushed a commit that referenced this issue Apr 6, 2016
Merge branch 'hotfix/#16-disable-nostojs-when-no-account' into develop
872b3f8
fairlane pushed a commit that referenced this issue Apr 6, 2016
Merge branch 'hotfix/#16-disable-nostojs-when-no-account'
0d210e3
@fairlane
Copy link
Contributor

fairlane commented Apr 6, 2016

Fixed - added check that Nosto account is defined before displaying the script tag

@fairlane fairlane closed this as completed Apr 6, 2016
@sweikas sweikas mentioned this issue May 11, 2022
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fairlane fairlane

Labels
bug
Projects
None yet
Milestone
1.0-RC2
Development

No branches or pull requests
2 participants
@pivulic @fairlane