Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nip46 signer may produce invalid events #222

Open
nostrband opened this issue May 8, 2024 · 0 comments
Open

nip46 signer may produce invalid events #222

nostrband opened this issue May 8, 2024 · 0 comments

Comments

@nostrband
Copy link

Nip46 signer client only uses the 'sig' field from an event returned from nip46 server:

https://github.com/nostr-dev-kit/ndk/blob/7cd209e41806124e1a7cf75de34d95b357cf7c6b/ndk/src/signers/nip46/index.ts#L242C1-L243C1

However, NDK's own nip46 server may change the to-be-signed event (in particular, it changes the created_at field for replaceable events), which means that nip46 client may get a signature from a different event, but will assume otherwise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant